Disallow reserved words for object binding pattern names #2809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| let id = parsePropertyName(); | ||
| if (id.kind === SyntaxKind.Identifier && token !== SyntaxKind.ColonToken) { | ||
| node.name = <Identifier>id; | ||
| let tokenIsIdentifier = isIdentifier(); |
There was a problem hiding this comment.
Did we decide to not just always parse out a property name, and then error later if the property name turns out to be a keyword?
There was a problem hiding this comment.
That is another approach we are considering. I do prefer it
|
Looks like we get this wrong for import / export specifiers as well! I tried the following: interface StringTree { }
export { StringTree as while };I got no error. |
… always an Identifier.
DanielRosenwasser
force-pushed
the
noReservedWordsInBindingPatterns
branch
from
c1d11cf to
4134d79
Compare
DanielRosenwasser
added a commit
that referenced
this pull request
Apr 18, 2015
Disallow reserved words for object binding pattern names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2722.