Skip to content

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jul 29, 2014

This is the first change to enable the language service on the new compiler. We are using the old syntactic model to drive syntactic features such as formatting, smart indent, and nav bar, and the new compiler to drive semantic operations like type info, and member list.
A few notes:

  • TypeScript module contains old syntactic model, ts module contain the new implementation, the plan is to migrate portions from TypeScript into ts and remove TypeScript entirely
  • Features implemented are not complete, we have failing tests to track the remaining work
  • Tests enabled are the ones that work now, I will be enabling more tests as we go
  • Some changes are needed on the LS interface layer, I have shimmed these in shims.ts, these hacks are needed to allow VS to use the resulting js with no changes; this makes it easier for us to test it, in the future, I will push these changes to the VS layer and clean up the shims.ts file
  • I would will consolidate document and soruceFile, as they are pretty much the same thing, except that one has extra fields, so I will extend sourceFile as we do with Node and Symbol on the services side and remove Document, but this will come in a different change
  • Breakpoint tests are failing, I need to investigate why, expect this in a future change as well
  • Exported constructs are either interfaces or factory functions, if you catch anything that is not either please flag it.
  • There are differences from the LanguageService-V2 branch, I will be reconsolidating these next.

@basarat
Copy link
Contributor

basarat commented Jul 31, 2014

participating

@mhegazy
Copy link
Contributor Author

mhegazy commented Jul 31, 2014

@CyrusNajmabadi , @basarat and @DanielRosenwasser -- any more comments?

mhegazy added a commit that referenced this pull request Aug 1, 2014
Enable basic Language Service on the new compiler
@mhegazy mhegazy merged commit 13bda52 into master Aug 1, 2014
@mhegazy mhegazy deleted the ls branch August 1, 2014 02:11
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants