-
Notifications
You must be signed in to change notification settings - Fork 13k
Enable basic Language Service on the new compiler #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lows the language service to set it, as sys is not defined in language service scenarios
…as ForEachChild expexts that
participating |
@CyrusNajmabadi , @basarat and @DanielRosenwasser -- any more comments? |
mhegazy
added a commit
that referenced
this pull request
Aug 1, 2014
Enable basic Language Service on the new compiler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first change to enable the language service on the new compiler. We are using the old syntactic model to drive syntactic features such as formatting, smart indent, and nav bar, and the new compiler to drive semantic operations like type info, and member list.
A few notes: