Wire getDefinitionAtPosition using the new compiler implementation #326
Conversation
| case SyntaxKind.ArrowFunction: | ||
| case SyntaxKind.ModuleDeclaration: | ||
| case SyntaxKind.ClassDeclaration: | ||
| // Label targets can not be accorss function boundries, so do not walk any further |
There was a problem hiding this comment.
We should still cross function boundaries. The compiler already binds them in this manner (and then reports you have an error if it crossed a boundary). This way, one can still do goto-def (esp. after getting that error).
There was a problem hiding this comment.
good point. will change it.
| var type = symbol && typeChecker.getTypeOfSymbol(symbol); | ||
| if (type) { | ||
| return { | ||
| memberName: new TypeScript.MemberNameString(typeChecker.typeToString(type)), |
There was a problem hiding this comment.
Don't you need the type name in the containeNode context eg. qualifying typeof expression?
* documentsByName to sourceFilesByName * getSymbolOfIdentifierLikeNode to getSymbolInfo
|
|
||
| var declarations = symbol.getDeclarations(); | ||
| var symbolName = typeChecker.symbolToString(symbol, node); | ||
| var symbolKind = getSymbolKind(symbol); |
There was a problem hiding this comment.
Why is symbolKind based on symbol and not declaration? eg. if it is fundule you want the 2 definitions with the correct function and module declaration kind?
There was a problem hiding this comment.
Cause I was just lazy.. will fix that a different change.
|
@sheetalkamat, @vladima and @DanielRosenwasser any more comments? |
| return true; | ||
| } | ||
|
|
||
| return false |
|
👍 |
Wire getDefinitionAtPosition using the new compiler implementation
There are some changes in behavior between old and new implementation, namely: