Skip to content

Conversation

sheetalkamat
Copy link
Member

To avoid getting MaxListenersExceededWarning on the stat watcher that is shared in node for a filename use it only once and manage callbacks instead.
Fixes #28690

Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it strives to make sure that if files overlap with multiple projects then we never create more than one watcher per file to save on memory 👍

@sheetalkamat sheetalkamat merged commit bf903eb into master Aug 2, 2019
@sheetalkamat sheetalkamat deleted the singleHostFsWatchFile branch August 2, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaxListenersExceededWarning when using tsc -b -w with more than 10 projects
2 participants