jsdoc template tags might be unmatched #32936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
approved these changes
Aug 16, 2019
|
Tests fail because quickinfo actually doesn't return anything in this case. I think that's fine. I updated the test and will merge when CI passes. |
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
* jsdoc template tags might be unmatched * Update fourslash test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick info tries to find the symbol for a type parameter when you ask for quick info in a
@templatetag. This applies to TS, where the@templatetag isn't actually bound.But the function might not actually have a matching type parameter. If it doesn't, services currently crashes because it assumes there is always a matching type parameter.
This bug is at least 2.5 years old, based on the git log.
Fixes #32935