Make it so all our diagnostics APIs return an independent set of diagnostics. #3558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nostics. In order to get all diagnostics, you must call all the APIs. And no APIs return diagnostics produced by other APIs. This is how things were before hte addition of the getCompletionOptionsDiagnostics API, and i'm returning things to that state.
Conflicts: src/services/services.ts
| @@ -105,7 +105,7 @@ namespace ts { | |||
| } | |||
|
|
|||
| export function getPreEmitDiagnostics(program: Program, sourceFile?: SourceFile): Diagnostic[] { | |||
| let diagnostics = program.getSyntacticDiagnostics(sourceFile).concat(program.getGlobalDiagnostics()).concat(program.getSemanticDiagnostics(sourceFile)); | |||
| let diagnostics = program.getOptionsDiagnostics().concat(program.getSyntacticDiagnostics(sourceFile)).concat(program.getGlobalDiagnostics()).concat(program.getSemanticDiagnostics(sourceFile)); | |||
There was a problem hiding this comment.
Split this into multiple lines
There was a problem hiding this comment.
Also can't concat just take multiple arguments?
There was a problem hiding this comment.
I agree with @DanielRosenwasser. Just check concat take multiple arguments which will clean up the expression a bit
CyrusNajmabadi
added a commit
that referenced
this pull request
Jun 18, 2015
Make it so all our diagnostics APIs return an independent set of diagnostics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get all diagnostics, you must call all the APIs. And no APIs return
diagnostics produced by other APIs. This is how things were before the addition
of the getCompletionOptionsDiagnostics API, and i'm returning things to that state.