Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.1] Undo #39258 (isArray changes) - see overview at #41808 #41849

Merged
merged 1 commit into from Dec 7, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Dec 7, 2020

In our latest design meeting we concluded that it was better to revert the isArray changes in #39258 - we'll probably come back to this with #36554.

Fixes #41808 by removing the .d.ts change. We think the assignability check is still worth keeping in.

@orta orta requested review from weswigham and RyanCavanaugh Dec 7, 2020
@orta orta self-assigned this Dec 7, 2020
@typescript-bot typescript-bot added Author: Team For Milestone Bug labels Dec 7, 2020
@orta orta added this to the TypeScript 4.1.2 milestone Dec 7, 2020
@DanielRosenwasser DanielRosenwasser changed the title Undo #39258 (isArray changes) see overview at #41808 for 4.1 [release-4.1] Undo #39258 (isArray changes) - see overview at #41808 Dec 7, 2020
@orta orta merged commit abf8815 into microsoft:release-4.1 Dec 7, 2020
10 checks passed
@lukeapage
Copy link

@lukeapage lukeapage commented Dec 12, 2020

Will you reopen #17002 which is now broken again in 4.1.3 (had to re ignore new errors when upgrading)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants