Skip to content

Do not show the additional file/errors table when there's 1 file with many errors #47345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 19, 2022

Conversation

orta
Copy link
Contributor

@orta orta commented Jan 7, 2022

E.g. this compile ending:

Found 2 errors in 1 file.

Errors  Files
     2 src/index.ts:14

Now shows as:

Found 2 errors in 1 file: src/index.ts:14

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 7, 2022
@orta orta requested a review from andrewbranch January 7, 2022 20:04
@andrewbranch
Copy link
Member

Some unit test failures lit up

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, we shouldn't display a line number in this new message.

@orta orta requested a review from DanielRosenwasser January 8, 2022 17:09
@orta
Copy link
Contributor Author

orta commented Jan 19, 2022

OK, I'm going to merge this as it has all feedback accepted, and I'd like to rebase #47126 on it

@orta orta merged commit 113a681 into microsoft:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants