Support resolution of any part of the RHS of an import #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
JsonFreeman
added a commit
that referenced
this pull request
Aug 20, 2014
Support resolution of any part of the RHS of an import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now resolveImport can resolve the entity name on the RHS of an import. But we only support resolving the whole entity name, not an arbitrary part of it. This change supports resolving an arbitrary part of an entity name. I've rewired resolveImport to call into this helper, and getTypeOfNode calls into it too now. This may be useful for the language service for go-to-definition.