Set impliedNodeFormat on sourceFile we get from host to ensure the field is set correctly #50977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
DanielRosenwasser
approved these changes
Sep 28, 2022
sheetalkamat
changed the title
DanielRosenwasser
approved these changes
Sep 28, 2022
weswigham
reviewed
Sep 28, 2022
weswigham
reviewed
Sep 28, 2022
amcasey
approved these changes
Oct 31, 2022
Member
|
@typescript-bot cherry-pick this to release-4.9 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #51363 for you. |
Member
|
I don't know if this will work after-the-fact but @typescript-bot user test tsserver |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 4bd8b9b. You can monitor the build here. |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 4bd8b9b. You can monitor the build here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue with using same source file between two programs when impliedNodeFormat was different in tsbuild mode.
Fixes #50872