feat(lib/esnext): add change array by copy types #51367
Merged
+618
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure why the test is failing. I'd assume it's flaky because it doesn't seem related to changing the type lib? |
|
@microsoft-github-policy-service agree |
|
I grabbed this PR and merged main into it, this is the test result: The former is because: You need to add new libs to The latter test failure goes away once the above is fixed. However, is this supposed to be in ES2023 and not esnext? (I'm not an expert at that part.) |
|
Yes, ES2023 is the right place for something that's stage 4 and will be part of the standard published as ES2023. |
…eat/change-array-copy
…Script into feat/change-array-copy
|
Can't be too safe this late in the game! @typescript-bot test this |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 0861e4c. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 0861e4c. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 0861e4c. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 0861e4c. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 0861e4c. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 0861e4c. You can monitor the build here. |
|
@DanielRosenwasser Here are the results of running the user test suite comparing Something interesting changed - please have a look. Details
|
|
@DanielRosenwasser Here are the results of running the user test suite comparing Something interesting changed - please have a look. Detailscreate-react-app
|
|
@DanielRosenwasser Here they are:
CompilerComparison Report - main..51367
System
Hosts
Scenarios
TSServerComparison Report - main..51367
System
Hosts
Scenarios
StartupComparison Report - main..51367
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Everything looks good! |
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsant-design/ant-design-pro
|
|
@DanielRosenwasser Here are some more interesting changes from running the top-repos suite Detailspnpm/pnpm
|
|
@DanielRosenwasser Here are some more interesting changes from running the top-repos suite Detailsvuejs/devtools
|
sandersn
requested changes
Feb 25, 2023
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Tim Buckley <timothypbuckley@gmail.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
|
Hi, did you reach a consensus on the last standing issue? |
sandersn
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Looks good, although I don't know if I want to ship this after the 5.1 beta.
@DanielRosenwasser I'm inclined to keep this until 5.2. Do you agree?
5 tasks
scmx
reviewed
Jun 1, 2023
Co-authored-by: Albert Arvidsson <albert.arvidsson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50333
Note: I decided to make
withandtoSplicedallow adding new types because I see the functions as the equivalent of creating array literals and spreading the original array:Prior art by Deno in denoland/deno#16499