Get occurrences for 'super' keywords #632
Merged
+247
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function getSuperContainer(node: Node): Node { | ||
| while (true) { | ||
| node = node.parent; | ||
| if (!node) { |
There was a problem hiding this comment.
still return undefined :)
you can also make this simpler with just:
while (node) {
switch (node.kind) { ... }
node = node.parent;
}
There was a problem hiding this comment.
The people have spoken, the undefined has prevailed 😉.
|
I do not see any tests.. |
DanielRosenwasser
force-pushed
the
getOccurrencesSuperThanksForAsking
branch
from
9e8f8ce to
0e93d28
Compare
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 9, 2014
…king Get occurrences for 'super' keywords
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.