Fixed bug where function type literals may omit their '=>'. #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
||
| var type: TypeNode; | ||
|
|
||
| if (returnToken === SyntaxKind.EqualsGreaterThanToken) { |
There was a problem hiding this comment.
i'd prefer if the caller was explicit about if the returnToken/returnType was optional or not. trying to reinfer that within this method is extremely subtle and confusing.
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 12, 2014
Fixed bug where function type literals may omit their '=>'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654.