Add support for syntactic classification. #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if (flags & SymbolFlags.TypeParameter) { | ||
| return ClassificationTypeNames.typeParameterName; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd put classifySymol after processNode just because it throws me off after not seeing classifySymbol being used
|
👍 |
| var sourceFile = getSourceFile(fileName); | ||
|
|
||
| var result: ClassifiedSpan[] = []; | ||
| processNode(sourceFile.getSourceFile()); |
There was a problem hiding this comment.
why not just processNode(sourceFile); ?
|
Do you need to add fourslash hooks for these? |
| } | ||
|
|
||
| function getSyntacticClassifications(fileName: string, span: TypeScript.TextSpan): ClassifiedSpan[] { | ||
| // doesn't use compiler - no need to synchronize with host |
There was a problem hiding this comment.
Why don't we use compiler in this case?
There was a problem hiding this comment.
Because it's a purely syntactic feature. The comment isn't great (it was copied from elsewhere). What we should be saying is "doesn't use semantics."
CyrusNajmabadi
added a commit
that referenced
this pull request
Sep 16, 2014
Add support for syntactic classification.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pending.