Add implementation for getNavigateToItems for the new compiler #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5211,8 +5211,7 @@ module ts { | |||
| var otherKind = node.kind === SyntaxKind.GetAccessor ? SyntaxKind.SetAccessor : SyntaxKind.GetAccessor; | |||
| var otherAccessor = <AccessorDeclaration>getDeclarationOfKind(node.symbol, otherKind); | |||
| if (otherAccessor) { | |||
| var visibilityFlags = NodeFlags.Private | NodeFlags.Public; | |||
| if (((node.flags & visibilityFlags) !== (otherAccessor.flags & visibilityFlags))) { | |||
| if (((node.flags & NodeFlags.AccessibilityModifier) !== (otherAccessor.flags & NodeFlags.AccessibilityModifier))) { | |||
There was a problem hiding this comment.
Why do we need to check accessibility for the getNavigateToItems ?
There was a problem hiding this comment.
no. we show local variables and local functions anyways, so private vs. public is not an issue. think of this more as a semantic search.
|
👍 |
Conflicts: src/services/services.ts
mhegazy
added a commit
that referenced
this pull request
Sep 16, 2014
Add implementation for getNavigateToItems for the new compiler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly kept the original behavior. Some minor changes: