Shim getSignatureAtPosition using the new signature help interfaces #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would hold off on this. getSigantureHelpCurrentArgumentState is going away tomorrow/friday when we get the next roslyn binaries. |
|
sure, this is more of a temporary change any ways. I do not think we should expose two ways to get to the same information. this is just to unblock users of Dev12, and make sure it is in the same place as other signature help interfaces, so we are aware of its existence. in the future, we can either push it to the managed side or tuck it in the shims. |
Conflicts: src/services/services.ts src/services/shims.ts
mhegazy
added a commit
that referenced
this pull request
Sep 25, 2014
Shim getSignatureAtPosition using the new signature help interfaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.