Only show first overload in a series of consecutive overload signatures #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for navigateTo
| overloadDeclaration = functionDeclaration; | ||
| } | ||
| break; | ||
|
|
There was a problem hiding this comment.
We are not walking the body of the function declaration this way, correct? If so we are missing inner functions.
There was a problem hiding this comment.
Right, this isn't finished, I was thinking about finishing this at home but I think I need to think out some of the semantics when dealing with incorrect code.
There was a problem hiding this comment.
This is going to get the first overload, not the last one. I think we should get the last one.
Current semantics: - If an overload lacks an implementation, go to the first implementation. - If an overload has any implementation, go to the first one. - If there are any declarations between an implementation and any overload, this will split the series of overloads (note that this is invalid code).
|
|
||
| forEachChild(sourceFile, function visit(node: Node): boolean { | ||
| forEachChild(sourceFile, function visit(node: Node): void { |
There was a problem hiding this comment.
I would pull the visit function out
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 7, 2014
Only show first overload in a series of consecutive overload signatures
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...for navigateTo.
Current semantics: