Fixes the name displayed in the rename dialog to be just symbol name instead of qualified path #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename dialog will use this name and scope name returned
…Name of the definition info. Fixes #652
| throw new Error(message); | ||
| } | ||
|
|
||
| private assertionMessage(message: string) { |
There was a problem hiding this comment.
this is a very specific operation. It should proibably be called something like messageAtLastKnownMarker
|
👍 |
|
@CyrusNajmabadi The assertions by default have that result. It was duplicate information, hence removed. |
sheetalkamat
added a commit
that referenced
this pull request
Oct 6, 2014
Fixes the name displayed in the rename dialog to be just symbol name instead of qualified path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.