Always use a hardcoded port #9985
Conversation
ghost
force-pushed
the
fix_runtests_browser
branch
from
d7e918e to
2873eea
Compare
ghost
mentioned this pull request
|
@Andy-MS If you're going to limit it to just port 8888, why take an argument at all? I don't think too many people are clamoring for this to be configurable. |
|
You might have a good point. Do you think we should just get rid of the "port" argument in gulpfile/jakefile? We should first make sure that no one is using it. |
|
Yeah, I'd just hardcode it to 8888 unless there are any objections. I don't have any. :) The only scenario I can think of is debugging TypeScript while running some other kind of local server. But the person that runs into that corner case can just hard code to some other port and recompile — I don't think it's a regularly occurring case. |
| @@ -10,37 +10,34 @@ import os = require("os"); | |||
| /// Command line processing /// | |||
|
|
|||
| if (process.argv[2] == '--help') { | |||
| console.log('Runs a node server on port 8888 by default, looking for tests folder in the current directory\n'); | |||
| console.log('Runs a node server on port 8888, looking for tests folder in the current directory\n'); | |||
| console.log('Syntax: node nodeServer.js [port] [typescriptEnlistmentDirectory] [tests] [--browser] [--verbose]\n'); | |||
There was a problem hiding this comment.
need to get rid of [port] here too
|
👍 |
ghost
changed the title
I had a PORT environment variable set to 80, and runtests-browser used that in some cases but not in others. Turns out it currently only works with a port of 8888, see #9987.