2.16.4 Upgrade + ZipSlip Expected File Conflict #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C#: Add change note
Ruby: add seperate additional steps between `YAML.parse*` methods and `to_ruby`
The `resources` folder never existed, this was probably introduced as a copy-paste mistake. Remove the rule.
…he public imports already are).
JS: Remove empty build target.
Ruby: Start building the language pack using bazel.
C++: Mark internal files in the old dataflow library as deprecated
Shared `View CFG` implementation
…n-fix Dataflow: Prevent bad join in FlowSummaryImpl::Private::Steps::summaryLocalStep.
Swift: Workaround for TypeDecl.getFullName issue.
…element Java: Cache interpretElement.
Ruby: Model Arel::Nodes::SqlLiteral.new
Python: Fix missing DictionaryElementContents
Python: Add consistency check for `PhaseDependentFlow`
Python: Add precision to NoSQL query
Web Cache Deception Vulnerability on Go Frameworks
Mention needed imports at top of "Analyzing data flow in Java"
…enotes Fix Markdown formatting on Ruby changenotes
Release preparation for version 2.16.4
… a given directory
…/2.16.4 Revert "Release preparation for version 2.16.4"
Release preparation for version 2.16.4
…/2.16.4 Revert "Release preparation for version 2.16.4"
Release preparation for version 2.16.4
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+136
to
+140
| catch | ||
| { | ||
| // not a valid `global.json` file | ||
| continue; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+217
to
+220
| catch (Exception e) | ||
| { | ||
| logger.LogError($"Error while searching for DLLs in '{path}': {e.Message}"); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+1038
to
+1041
| catch (Exception exc) | ||
| { | ||
| logger.LogError($"Failed to update target framework in {tempDir.FullName}: {exc}"); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+247
to
+260
| foreach (var version in versions) | ||
| { | ||
| if (!attempted.Add(version)) | ||
| continue; | ||
|
|
||
| installScript = BuildScript.Bind(installScript, combinedExit => | ||
| { | ||
| logger.LogInfo($"Attempting to download .NET {version}"); | ||
|
|
||
| // When there are multiple versions requested, we want to try to fetch them all, reporting | ||
| // a successful exit code when at least one of them succeeds | ||
| return combinedExit != 0 ? getInstall(version) : BuildScript.Bind(getInstall(version), _ => BuildScript.Success); | ||
| }); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
ropwareJB
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual merge of 2.16.4 (to also resolve zipslip .expected file conflict)