Merge pull request #289 from microsoft/ve-networkchanges

Prajwal-Microsoft · web-flow · commit 4b48a18ad8ae · 2025-10-15T18:23:26.000+05:30
fix: Adding condition to keyvault diagnostic settings
diff --git a/infra/modules/key-vault.bicep b/infra/modules/key-vault.bicep
@@ -89,7 +89,7 @@ module avmKeyVault 'br/public:avm/res/key-vault/vault:0.13.0' = {
     enableRbacAuthorization: enableRbacAuthorization
     createMode: createMode
     enableTelemetry: enableTelemetry
-    diagnosticSettings: [{ workspaceResourceId: logAnalyticsWorkspaceResourceId }]
+    diagnosticSettings: empty(logAnalyticsWorkspaceResourceId) ? null : [{ workspaceResourceId: logAnalyticsWorkspaceResourceId }]
     networkAcls: networkAcls
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ module avmKeyVault 'br/public:avm/res/key-vault/vault:0.13.0' = {`
`89`	`89`	`enableRbacAuthorization: enableRbacAuthorization`
`90`	`90`	`createMode: createMode`
`91`	`91`	`enableTelemetry: enableTelemetry`
`92`		`- diagnosticSettings: [{ workspaceResourceId: logAnalyticsWorkspaceResourceId }]`
	`92`	`+ diagnosticSettings: empty(logAnalyticsWorkspaceResourceId) ? null : [{ workspaceResourceId: logAnalyticsWorkspaceResourceId }]`
`93`	`93`	`networkAcls: networkAcls`
`94`	`94`	`}`
`95`	`95`	`}`