Skip to content

Removing argument 'is_train' which is not used in SeqDecoder.finalise_minibatch #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

Removing argument 'is_train' which is not used in SeqDecoder.finalise_minibatch #5

merged 1 commit into from
Jul 30, 2019

Conversation

urialon
Copy link
Contributor

@urialon urialon commented Jul 30, 2019

This argument raises an exception because:

  • SeqDecoder.finalise_minibatch(..) requires a named argument is_train, but does not use it
  • Seq2SeqModel calls self._decoder_model.finalise_metadata with is_train
  • Graph2SeqModel calls self._decoder_model.finalise_metadata without is_train (so it is currently broken)

By removing this unused argument, Graph2Seq is fixed.

@msftclas
Copy link

msftclas commented Jul 30, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@mmjb mmjb merged commit 8967fac into microsoft:master Jul 30, 2019
@urialon urialon deleted the fix_finalise branch July 30, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mmjb mmjb mmjb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urialon @msftclas @mmjb