Skip to content

Removing argument 'is_train' which is not used in SeqDecoder.finalise_minibatch #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Removing argument 'is_train' which is not used in SeqDecoder.finalise_minibatch #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Models/exprsynth/seq2seqmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def _extend_minibatch_by_sample(self, batch_data: Dict[str, Any], sample: Dict[s

def _finalise_minibatch(self, batch_data: Dict[str, Any], is_train: bool) -> Dict[tf.Tensor, Any]:
minibatch = super()._finalise_minibatch(batch_data, is_train)
self._decoder_model.finalise_minibatch(batch_data, minibatch, is_train)
self._decoder_model.finalise_minibatch(batch_data, minibatch)
return minibatch

# ------- These are the bits that we only need for test-time:
Expand Down
2 changes: 1 addition & 1 deletion Models/exprsynth/seqdecoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def extend_minibatch_by_sample(self, batch_data: Dict[str, Any], sample: Dict[st
batch_data['target_token_ids'].append(sample['target_token_ids'])
batch_data['target_token_ids_mask'].append(sample['target_token_ids_mask'])

def finalise_minibatch(self, batch_data: Dict[str, Any], minibatch: Dict[tf.Tensor, Any], is_train: bool) -> None:
def finalise_minibatch(self, batch_data: Dict[str, Any], minibatch: Dict[tf.Tensor, Any]) -> None:
write_to_minibatch(minibatch, self.placeholders['target_token_ids'], batch_data['target_token_ids'])
write_to_minibatch(minibatch, self.placeholders['target_token_ids_mask'], batch_data['target_token_ids_mask'])

Expand Down