FIX: Static UUID variable causes pytest crash #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Problem
Pytest test suite (335+ tests) was crashing on exit with:
The crash occurred after all tests passed, during Python shutdown on Windows x64 and macOS.
Root Cause
Static
pybind11::module_
andpybind11::object
instances inBindParameterArray()
function (lines 2072-2073) were being destroyed during C++ static destruction phase, which happens after Python has released the GIL and begun finalization.When the destructors called
Py_XDECREF
, Python's_Py_GetConfig()
was invoked without the GIL, causing the fatal error.Solution
Moved UUID class caching to module initialization level using a helper function. This ensures the Python object lifecycle is managed within pybind11's module context, avoiding destructor calls during finalization.
The
_get_uuid_class()
helper is defined at module initialization and maintains a static cache that lives for the module's lifetime, properly integrated with pybind11's lifecycle management.Testing
Impact