Skip to content

FIX: Static UUID variable causes pytest crash #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

FIX: Static UUID variable causes pytest crash #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions mssql_python/pybind/ddbc_bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2069,8 +2069,10 @@ SQLRETURN BindParameterArray(SQLHANDLE hStmt,
SQLGUID* guidArray = AllocateParamBufferArray<SQLGUID>(tempBuffers, paramSetSize);
strLenOrIndArray = AllocateParamBufferArray<SQLLEN>(tempBuffers, paramSetSize);

static py::module_ uuid_mod = py::module_::import("uuid");
static py::object uuid_class = uuid_mod.attr("UUID");
// Get cached UUID class from module-level helper
// This avoids static object destruction issues during Python finalization
py::object uuid_class = py::module_::import("mssql_python.ddbc_bindings").attr("_get_uuid_class")();

for (size_t i = 0; i < paramSetSize; ++i) {
const py::handle& element = columnValues[i];
std::array<unsigned char, 16> uuid_bytes;
Expand Down Expand Up @@ -3903,6 +3905,14 @@ PYBIND11_MODULE(ddbc_bindings, m) {
});


// Module-level UUID class cache
// This caches the uuid.UUID class at module initialization time and keeps it alive
// for the entire module lifetime, avoiding static destructor issues during Python finalization
m.def("_get_uuid_class", []() -> py::object {
static py::object uuid_class = py::module_::import("uuid").attr("UUID");
return uuid_class;
}, "Internal helper to get cached UUID class");

// Add a version attribute
m.attr("__version__") = "1.0.0";

Expand Down