Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship conpty.dll/OpenConsole.exe with opt-in experimental option useConptyDll #694

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 1, 2024

This also includes header files for node v20.14.0 so that go to def/etc. work in the C++ vscode extension.

Part of microsoft/vscode#224488

@Tyriar Tyriar added this to the 1.1.0 milestone Aug 1, 2024
@Tyriar Tyriar requested a review from rzhao271 August 1, 2024 15:35
@Tyriar Tyriar self-assigned this Aug 1, 2024
@Tyriar Tyriar enabled auto-merge August 1, 2024 15:37
@Tyriar Tyriar merged commit bd7fa4f into main Aug 1, 2024
2 checks passed
@Tyriar Tyriar deleted the tyriar/conptydll branch August 1, 2024 16:55
@deepak1556
Copy link
Contributor

@Tyriar why not point to the node-gyp which your installation of node uses instead of bundling it in the repo ?

@Tyriar
Copy link
Member Author

Tyriar commented Aug 27, 2024

@deepak1556 how would you do that in a portable way as node could be installed anywhere?

@deepak1556
Copy link
Contributor

Prefer compile_commands which makes intellisense work on the header and library paths specified to the compiler at build time. The c++ extensions seems to support it https://code.visualstudio.com/docs/cpp/c-cpp-properties-schema-reference#_configuration-properties. Most build systems out there should support generating this file. For node-gyp refer to nodejs/node-gyp#1526

The dependency added in this PR will be hard to maintain and quickly go out of sync, it would be best if we avoid syncing it to the repo.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 27, 2024

I only realized it was a million lines after merging 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants