Skip to content

Conversation

justinchuby
Copy link
Collaborator

Update torch api error message to include value names when raising error on uninitialized values

…alized values

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates error handling in the torch API to provide more detailed error messages when models contain uninitialized values. The change enhances debugging by including specific value names in the error message.

  • Replaces immediate error raising with collection of uninitialized value names
  • Updates error message to include the specific names of uninitialized values

@justinchuby justinchuby enabled auto-merge (squash) October 3, 2025 05:33
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.93%. Comparing base (81f8444) to head (fd8facc).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/_framework_apis/torch_2_5.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2599   +/-   ##
=======================================
  Coverage   69.93%   69.93%           
=======================================
  Files         223      223           
  Lines       26323    26323           
  Branches     2605     2604    -1     
=======================================
  Hits        18409    18409           
  Misses       7002     7002           
  Partials      912      912           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit b7ccc86 into main Oct 3, 2025
32 checks passed
@justinchuby justinchuby deleted the justinchu/uninit-message branch October 3, 2025 16:37
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants