Skip to content

Update torch api error message to include value names #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Update torch api error message to include value names #2599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions onnxscript/_framework_apis/torch_2_5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,14 @@ def save_model_with_external_data(model: ir.Model, model_path: str | os.PathLike
"""Save the model with external data. The model is unchanged after saving."""

# TODO(#1835): Decide if we want to externalize large attributes as well
for value in model.graph.initializers.values():
if value.const_value is None:
raise ValueError(
"The model contains uninitialized initializer values. "
"Please make sure all initializer values are initialized."
)
uninitialized_values = [
value.name for value in model.graph.initializers.values() if value.const_value is None
]
if uninitialized_values:
raise ValueError(
f"The model contains uninitialized initializer values ({uninitialized_values}). "
"Please make sure all initializer values are initialized."
)
destination_path = pathlib.Path(model_path)
data_path = f"{destination_path.name}.data"

Expand Down
Loading