Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webkit): roll to r1908 #27049

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat(webkit): roll to r1908 #27049

merged 2 commits into from
Sep 13, 2023

Conversation

playwrightmachine
Copy link
Collaborator

@playwrightmachine playwrightmachine commented Sep 13, 2023 •
edited by mxschmitt
Loading

For the record, these are the platforms which ship libsoup3 now:

Ubuntu20/Debian11.

❯ find . -name \*libsoup\*
./webkit-ubuntu-20.04-arm64/minibrowser-gtk/sys/lib/libsoup-3.0.so.0.0.5
./webkit-ubuntu-20.04-arm64/minibrowser-gtk/sys/lib/libsoup-3.0.so.0
./webkit-ubuntu-20.04-arm64/minibrowser-wpe/sys/lib/libsoup-3.0.so.0.0.5
./webkit-ubuntu-20.04-arm64/minibrowser-wpe/sys/lib/libsoup-3.0.so.0
./webkit-ubuntu-20.04/minibrowser-gtk/sys/lib/libsoup-3.0.so.0.0.5
./webkit-ubuntu-20.04/minibrowser-gtk/sys/lib/libsoup-3.0.so.0
./webkit-ubuntu-20.04/minibrowser-wpe/sys/lib/libsoup-3.0.so.0.0.5
./webkit-ubuntu-20.04/minibrowser-wpe/sys/lib/libsoup-3.0.so.0
./webkit-debian-11/minibrowser-gtk/sys/lib/libsoup-3.0.so.0.0.5
./webkit-debian-11/minibrowser-gtk/sys/lib/libsoup-3.0.so.0
./webkit-debian-11/minibrowser-wpe/sys/lib/libsoup-3.0.so.0.0.5
./webkit-debian-11/minibrowser-wpe/sys/lib/libsoup-3.0.so.0
./webkit-debian-11-arm64/minibrowser-gtk/sys/lib/libsoup-3.0.so.0.0.5
./webkit-debian-11-arm64/minibrowser-gtk/sys/lib/libsoup-3.0.so.0
./webkit-debian-11-arm64/minibrowser-wpe/sys/lib/libsoup-3.0.so.0.0.5
./webkit-debian-11-arm64/minibrowser-wpe/sys/lib/libsoup-3.0.so.0

@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Sep 13, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › reporter-html.spec.ts:1491:7 › created › labels › filter should update stats
❌ [playwright-test] › reporter-html.spec.ts:1491:7 › merged › labels › filter should update stats

5 flaky ⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-python.spec.ts:74:5 › should save the codegen output to a file if specified
⚠️ [webkit] › page/page-goto.spec.ts:266:3 › should fail when navigating to bad SSL

25585 passed, 599 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt merged commit bf35390 into main Sep 13, 2023
@mxschmitt mxschmitt deleted the roll-into-pw-webkit/1908 branch September 13, 2023 15:40
@commit-lint commit-lint bot mentioned this pull request Sep 13, 2023
Merged
@github-actions
Copy link
Contributor

Test results for "tests 2"

52 failed
❌ [chromium] › library\beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium] › library\beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium] › library\beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium] › library\beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium] › library\beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium] › library\beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium] › library\beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium] › library\browser.spec.ts:19:5 › should return browserType
❌ [chromium] › library\browser.spec.ts:23:5 › should create new page @smoke
❌ [chromium] › library\browser.spec.ts:37:5 › should throw upon second create new page
❌ [chromium] › library\browser.spec.ts:45:5 › version should work
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:182:15 › should isolate cookies between launches
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:272:3 › should not set a cookie with blank page URL
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:287:3 › should not set a cookie on a data URL page
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium] › library\browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium] › library\browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium] › library\browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium] › library\browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium] › library\browsercontext-basic.spec.ts:21:3 › should create new context @smoke
❌ [chromium] › library\browsercontext-basic.spec.ts:32:3 › window.open should use parent tab context
❌ [chromium] › library\browsercontext-basic.spec.ts:44:3 › should isolate localStorage and cookies @smoke
❌ [chromium] › library\browsercontext-basic.spec.ts:89:3 › should propagate default viewport to the page
❌ [chromium] › library\browsercontext-basic.spec.ts:96:3 › should make a copy of default viewport
❌ [chromium] › library/emulation-focus.spec.ts:104:3 › should not affect screenshots
❌ [chromium] › library/video.spec.ts:429:5 › screencast › should scale frames down to the requested size

102 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\inspector\cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [chromium] › library\inspector\cli-codegen-2.spec.ts:24:7 › cli codegen › should contain open page
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page\page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium] › page\page-wait-for-selector-2.spec.ts:58:3 › should wait for visible recursively
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-proxy.spec.ts:322:3 › should exclude patterns
⚠️ [chromium] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\inspector\cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [firefox] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library\proxy.spec.ts:179:3 › should exclude patterns
⚠️ [firefox] › page\page-fill.spec.ts:285:3 › should be able to fill exponent into the input[type=number]
⚠️ [firefox] › page\page-goto.spec.ts:192:3 › should work with redirects
⚠️ [firefox] › library/capabilities.spec.ts:256:3 › requestFullscreen
⚠️ [firefox] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [firefox] › library/video.spec.ts:334:5 › screencast › should capture navigation
⚠️ [firefox] › page/page-click.spec.ts:414:3 › should click a very large button with offset
⚠️ [firefox] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library\browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox] › library\browsercontext-route.spec.ts:154:3 › should use Set-Cookie header in future requests
⚠️ [firefox] › library\inspector\cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox] › library\trace-viewer.spec.ts:272:1 › should show snapshot URL
⚠️ [firefox] › library\tracing.spec.ts:275:5 › should overwrite existing file
⚠️ [firefox] › page\page-add-script-tag.spec.ts:93:3 › should throw when added with content to the CSP page
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › library/inspector/cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library/inspector/cli-codegen-2.spec.ts:169:7 › cli codegen › should clear files
⚠️ [firefox] › page/page-evaluate.spec.ts:512:3 › should transfer 100Mb of data from page to node.js
⚠️ [firefox] › library/proxy.spec.ts:179:3 › should exclude patterns
⚠️ [firefox] › library\browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox] › library\browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset
⚠️ [firefox] › library\signals.spec.ts:25:5 › should close the browser when the node process closes
⚠️ [chromium] › library/browsercontext-events.spec.ts:19:5 › console event should work @smoke
⚠️ [chromium] › page/page-event-request.spec.ts:44:3 › should report requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:506:5 › should export trace concurrently to second navigation
⚠️ [chromium] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [chromium] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium] › library\browsercontext-viewport-mobile.spec.ts:57:5 › mobile viewport › should be detectable by Modernizr
⚠️ [chromium] › library\browsercontext-viewport.spec.ts:94:3 › should not have touch by default
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-screenshot.spec.ts:610:5 › page screenshot animations › should stop animations that happen right before screenshot
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:257:7 › cli codegen › should fill japanese text
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:667:7 › cli codegen › should assert navigation
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library\har.spec.ts:424:3 › should return receive time
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:55:7 › cli codegen › should ignore programmatic events
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:196:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:340:7 › cli codegen › should press
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:403:7 › cli codegen › should record ArrowDown
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:450:7 › cli codegen › should check
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:625:7 › cli codegen › should await popup
⚠️ [webkit] › library\inspector\cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [webkit] › page\elementhandle-misc.spec.ts:20:3 › should hover
⚠️ [webkit] › page\page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › page\page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [webkit] › library\browsercontext-viewport-mobile.spec.ts:57:5 › mobile viewport › should be detectable by Modernizr
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:94:3 › should not have touch by default
⚠️ [webkit] › library\har.spec.ts:424:3 › should return receive time
⚠️ [webkit] › library\inspector\cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [webkit] › library\tracing.spec.ts:469:5 › should work with multiple chunks
102 interrupted ⚠️ [chromium] › library\browsercontext-add-cookies.spec.ts:392:3 › should not block third party SameSite=None cookies

177742 passed, 11182 skipped
✔️✔️✔️

Merge workflow run.

github-actions bot added a commit that referenced this pull request Sep 13, 2023
@github-actions
cherry-pick(#27049): feat(webkit): roll to r1908
b314468
mxschmitt pushed a commit that referenced this pull request Sep 13, 2023
@playwrightmachine @github-actions
cherry-pick(#27049): feat(webkit): roll to r1908 (#27055)
a0a099f 
This PR cherry-picks the following commits:

- bf35390

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@playwrightmachine @Germandrummer92
feat(webkit): roll to r1908 (microsoft#27049)
d9eb9aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
CQ1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@playwrightmachine @yury-s @mxschmitt