Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#27049): feat(webkit): roll to r1908 #27055

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

playwrightmachine
Copy link
Collaborator

This PR cherry-picks the following commits:

@mxschmitt mxschmitt merged commit a0a099f into release-1.38 Sep 13, 2023
@mxschmitt mxschmitt deleted the cherry-pick-1.38-2023-09-13-16-05-23 branch September 13, 2023 16:28
@github-actions
Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [firefox] › page/page-request-continue.spec.ts:271:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live

25607 passed, 600 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 2"

53 failed
❌ [chromium] › page\page-leaks.spec.ts:62:5 › click should not leak
❌ [chromium] › library\beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium] › library\beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium] › library\beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium] › library\beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium] › library\beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium] › library\beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium] › library\beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium] › library\browser.spec.ts:19:5 › should return browserType
❌ [chromium] › library\browser.spec.ts:23:5 › should create new page @smoke
❌ [chromium] › library\browser.spec.ts:37:5 › should throw upon second create new page
❌ [chromium] › library\browser.spec.ts:45:5 › version should work
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:182:15 › should isolate cookies between launches
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:272:3 › should not set a cookie with blank page URL
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:287:3 › should not set a cookie on a data URL page
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium] › library\browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium] › library\browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium] › library\browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium] › library\browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium] › library\browsercontext-basic.spec.ts:21:3 › should create new context @smoke
❌ [chromium] › library\browsercontext-basic.spec.ts:32:3 › window.open should use parent tab context
❌ [chromium] › library\browsercontext-basic.spec.ts:44:3 › should isolate localStorage and cookies @smoke
❌ [chromium] › library\browsercontext-basic.spec.ts:89:3 › should propagate default viewport to the page
❌ [chromium] › library\browsercontext-basic.spec.ts:96:3 › should make a copy of default viewport
❌ [chromium] › library/emulation-focus.spec.ts:104:3 › should not affect screenshots
❌ [chromium] › library/video.spec.ts:429:5 › screencast › should scale frames down to the requested size

105 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:259:3 › ElementHandle.boundingBox() should work
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [chromium] › library/proxy.spec.ts:308:3 › should use SOCKS proxy for websocket requests
⚠️ [chromium] › library/browsercontext-proxy.spec.ts:322:3 › should exclude patterns
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:506:5 › should export trace concurrently to second navigation
⚠️ [chromium] › library\browsercontext-viewport-mobile.spec.ts:58:5 › mobile viewport › should be detectable by Modernizr
⚠️ [chromium] › library\browsercontext-viewport.spec.ts:94:3 › should not have touch by default
⚠️ [chromium] › library\proxy.spec.ts:248:3 › does launch without a port
⚠️ [chromium] › library/trace-viewer.spec.ts:249:1 › should have network request overrides
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-screenshot.spec.ts:610:5 › page screenshot animations › should stop animations that happen right before screenshot
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:450:7 › cli codegen › should check
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-click.spec.ts:979:3 › should click a button that is overlayed by a permission popup
⚠️ [chromium] › library\inspector\pause.spec.ts:161:5 › pause › should highlight pointer
⚠️ [chromium] › page\page-click.spec.ts:979:3 › should click a button that is overlayed by a permission popup
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:259:3 › ElementHandle.boundingBox() should work
⚠️ [chromium] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [chromium] › page/page-event-request.spec.ts:44:3 › should report requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\beforeunload.spec.ts:20:3 › should close browser with beforeunload page
⚠️ [chromium] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library\beforeunload.spec.ts:20:3 › should close browser with beforeunload page
⚠️ [firefox] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › page/page-request-continue.spec.ts:271:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › library/browsercontext-network-event.spec.ts:58:3 › BrowserContext.Events.RequestFailed
⚠️ [firefox] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library/capabilities.spec.ts:256:3 › requestFullscreen
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › library/video.spec.ts:334:5 › screencast › should capture navigation
⚠️ [firefox] › page/page-click.spec.ts:414:3 › should click a very large button with offset
⚠️ [firefox] › page/page-goto.spec.ts:431:3 › js redirect overrides url bar navigation
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › library/video.spec.ts:712:5 › screencast › should capture full viewport on hidpi
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › library\browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
⚠️ [firefox] › library\browsercontext-pages.spec.ts:35:3 › frame.focus should work multiple times
⚠️ [firefox] › library\har.spec.ts:176:3 › should include form params
⚠️ [firefox] › library\inspector\cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox] › library\signals.spec.ts:25:5 › should close the browser when the node process closes
⚠️ [firefox] › library\trace-viewer.spec.ts:1000:1 › should pick locator in iframe
⚠️ [firefox] › library\tracing.spec.ts:275:5 › should overwrite existing file
⚠️ [firefox] › page\elementhandle-scroll-into-view.spec.ts:119:3 › should timeout waiting for visible
⚠️ [firefox] › page\page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library\browsertype-connect.spec.ts:78:5 › launchServer › should connect over wss
⚠️ [firefox] › library\browsertype-connect.spec.ts:383:5 › launchServer › should terminate network waiters
⚠️ [chromium] › library/browsercontext-fetch.spec.ts:1039:3 › should abort requests when browser context closes
⚠️ [chromium] › page/page-click.spec.ts:979:3 › should click a button that is overlayed by a permission popup
⚠️ [chromium] › page/page-event-request.spec.ts:44:3 › should report requests and responses handled by service worker
⚠️ [chromium] › page/page-screenshot.spec.ts:752:5 › page screenshot animations › should trigger particular events for css transitions
⚠️ [chromium] › library/browsercontext-fetch.spec.ts:1039:3 › should abort requests when browser context closes
⚠️ [chromium] › library/inspector/cli-codegen-2.spec.ts:518:7 › cli codegen › should fill tricky characters
⚠️ [chromium] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing
⚠️ [chromium] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium] › library\beforeunload.spec.ts:20:3 › should close browser with beforeunload page
⚠️ [chromium] › library\browsercontext-reuse.spec.ts:131:1 › should not cache resources
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-screenshot.spec.ts:610:5 › page screenshot animations › should stop animations that happen right before screenshot
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [webkit] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [webkit] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit] › library/browsercontext-fetch.spec.ts:1039:3 › should abort requests when browser context closes
⚠️ [webkit] › library\browsercontext-reuse.spec.ts:206:1 › should reset mouse position
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library\har.spec.ts:424:3 › should return receive time
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:158:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:323:7 › cli codegen › should fill [contentEditable]
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:340:7 › cli codegen › should press
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:520:7 › cli codegen › should uncheck
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:625:7 › cli codegen › should await popup
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:667:7 › cli codegen › should assert navigation
⚠️ [webkit] › page\page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › page\page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [webkit] › page\page-history.spec.ts:39:3 › page.goBack should work with HistoryAPI
⚠️ [webkit] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-goto.spec.ts:266:3 › should fail when navigating to bad SSL
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-goto.spec.ts:266:3 › should fail when navigating to bad SSL
⚠️ [webkit] › library\browsercontext-viewport-mobile.spec.ts:58:5 › mobile viewport › should be detectable by Modernizr
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:94:3 › should not have touch by default

177683 passed, 11180 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants