Skip to content

Conversation

Saadnajmi
Copy link
Collaborator

Backport #1132 to 0.66-stable

…ers (microsoft#1132)

* Only pass height or width if needed

* fix typo

* Update RCTScrollContentLocalData.h
@Saadnajmi Saadnajmi requested a review from a team as a code owner April 23, 2022 00:28
@pull-bot
Copy link

Fails
🚫

❔ This pull request needs a description.

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 2b8a8ed

@Saadnajmi Saadnajmi merged commit f5622ec into microsoft:0.66-stable Apr 23, 2022
@Saadnajmi Saadnajmi deleted the scrollview-66 branch June 24, 2022 22:41
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
…h scrollers (microsoft#1132) (microsoft#1133)"

This reverts commit f5622ec.

# Conflicts:
#	React/Views/ScrollView/RCTScrollContentView.m
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
…h scrollers (microsoft#1132) (microsoft#1133)"

This reverts commit f5622ec.

# Conflicts:
#	React/Views/ScrollView/RCTScrollContentView.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants