Fix template project specifying wrong constraints #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s; branch 'main' of github.com:microsoft/react-native-macos into fix-template
Saadnajmi
changed the title
lyzhan7
approved these changes
Dec 13, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Resolves #1397. Seems this typo has existed since the beginning of the open source repo.
Changelog
[macOS] [Fixed] - Fix template project specifying wrong constraints
Test Plan
Used
yarn linkto use my local version of React Native macOS to create a new test project using the instructions here https://microsoft.github.io/react-native-windows/docs/0.64/rnm-getting-started (I used 0.68 instead of 0.64).Confirmed the typo is no longer there.