Add missing scaleFactor argument to Fabric RCTViewComponentView.mm #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last change we need to make to enable Fabric + iOS Testplan: in packages/rn-tester run: bundle install && USE_FABRIC=1 bundle exec pod install Open Xcode and run on iOS Simluator
Saadnajmi
approved these changes
Nov 3, 2022
Saadnajmi
approved these changes
Nov 10, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…icrosoft#1464) This is the last change we need to make to enable Fabric + iOS Testplan: in packages/rn-tester run: bundle install && USE_FABRIC=1 bundle exec pod install Open Xcode and run on iOS Simluator
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…icrosoft#1464) This is the last change we need to make to enable Fabric + iOS Testplan: in packages/rn-tester run: bundle install && USE_FABRIC=1 bundle exec pod install Open Xcode and run on iOS Simluator
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…icrosoft#1464) This is the last change we need to make to enable Fabric + iOS Testplan: in packages/rn-tester run: bundle install && USE_FABRIC=1 bundle exec pod install Open Xcode and run on iOS Simluator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This is the last change we need to make to enable Fabric + iOS
Changelog
[macOS] [Fixed] - Add missing scaleFactor argument to Fabric RCTViewComponentView.mm
Test Plan
in packages/rn-tester run:
bundle install && USE_FABRIC=1 bundle exec pod installOpen Xcode and run on iOS Simulator
Screen.Recording.2022-11-03.at.12.05.21.PM.mov