Skip to content

Conversation

dotnetjunky
Copy link

@dotnetjunky dotnetjunky commented Aug 27, 2019

Summary

Fix the Yellow Box style on win32.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Description of changes

Fix the styling of YellowBox on win32. We have supported the % values for 'width' and 'height' properties, so I'm removing the forked code where we are hard coding the width of the yellow box.

However, the 'bottom' property still hasn't supported % value. Therefore, we still need to fork the code for that.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@pull-bot

This comment has been minimized.

}

const listStyle = {
width: Platform.OS === 'win32' ? '85%' : undefined,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going wrong here that we need the width on win32 but not the other platforms?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile, the Yellow Box covers the entire screen, and the Dismiss All button is rendered at the bottom.

On win32, somebody (probably Coates) made a change to show the maximum 3 warnings at the bottom of the UI. The Dismiss All button is rendered to the right. This is my hacky attempt to make sure the Dismiss All button is not covered by the warning texts.

@dotnetjunky dotnetjunky merged commit 73a8a7e into microsoft:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants