Unfork RCTLogBox #1501
Merged
Unfork RCTLogBox #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
force-pushed
the
logBoxView
branch
from
2a2c002 to
8055fb6
Compare
Saadnajmi
reviewed
Nov 14, 2022
|
@amgleitman any opinions? I remember you ran into this same diff during one of your last merges. |
christophpurrer
force-pushed
the
logBoxView
branch
from
8055fb6 to
a20fcd9
Compare
Saadnajmi
approved these changes
Nov 15, 2022
These files have some 'unnecessary' changes which make it hard(er) to merge in recent changes as: facebook@37e5fa3a6ce Hence unforking them were possible
christophpurrer
force-pushed
the
logBoxView
branch
from
a20fcd9 to
3ab377c
Compare
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
These files have some 'unnecessary' changes which make it hard(er) to merge in recent changes as: facebook@37e5fa3a6ce Hence unforking them were possible
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
These files have some 'unnecessary' changes which make it hard(er) to merge in recent changes as: facebook@37e5fa3a6ce Hence unforking them were possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
These files have some 'unnecessary' changes which make it hard(er) to merge in recent changes as: facebook@37e5fa3a6ce
Hence un-forking them were possible
Changelog
[macOS][Fixed] Unfork RCTLogBox
Test Plan
CircleCi for macOS and iOS
Show some beautiful logboxes ...
Screen.Recording.2022-11-13.at.10.57.19.PM.mov