Skip to content

A couple of minor fixes in NativeToJsBridge #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2019
Merged

A couple of minor fixes in NativeToJsBridge #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ReactCommon/cxxreact/NativeToJsBridge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ void NativeToJsBridge::callFunction(
#else
(void)(systraceCookie);
#endif
SystraceSection s("NativeToJsBridge::callFunction", "module", module, "method", method);
// This is safe because we are running on the executor's thread: it won't
// destruct until after it's been unregistered (which we check above) and
// that will happen on this thread
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/cxxreact/NativeToJsBridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class NativeToJsBridge {
bool m_applicationScriptHasFailure = false;

#ifdef WITH_FBSYSTRACE
std::atomic_uint_least32_t m_systraceCookie = ATOMIC_VAR_INIT();
std::atomic_uint_least32_t m_systraceCookie{};
#endif
};

Expand Down