Skip to content

[0.68] Remove faulty logic in ScrollView #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022
Merged

[0.68] Remove faulty logic in ScrollView #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions React/Views/ScrollView/RCTScrollView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,21 +333,6 @@ - (void)didMoveToWindow
#endif // TODO(macOS GH#774)

#if TARGET_OS_OSX // [TODO(macOS GH#774)
- (BOOL)canBecomeFirstResponder
{
return YES;
}

- (BOOL)becomeFirstResponder
{
return YES;
}

- (BOOL)resignFirstResponder
{
return YES;
}

- (void)setAccessibilityLabel:(NSString *)accessibilityLabel
{
[super setAccessibilityLabel:accessibilityLabel];
Expand Down Expand Up @@ -532,21 +517,6 @@ - (RCTUIView *)contentView // TODO(macOS ISS#3536887)
return _scrollView.documentView;
}

- (BOOL)canBecomeFirstResponder
{
return [_scrollView canBecomeFirstResponder];
}

- (BOOL)becomeFirstResponder
{
return [_scrollView becomeFirstResponder];
}

- (BOOL)resignFirstResponder
{
return [_scrollView resignFirstResponder];
}

- (void)setAccessibilityLabel:(NSString *)accessibilityLabel
{
[_scrollView setAccessibilityLabel:accessibilityLabel];
Expand Down