Remove deprecated prop-types reference for Text

[shwanton]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

The PropTypes package is deprecated on RN Core.
To help folks get off of the package, this deprecation path was left in place.

Removing the reference fixes #1433

NOTE: This was recently un-deprecated by the core team to allow more time for folks to migrate: facebook@b966d29
I'm assuming desktop doesn't have the same legacy issues so I think it's fine to remove.

Changelog

[macOS] [Fix] - Remove reference to deprecated package in TextView

Test Plan

Before

CleanShot.2022-11-18.at.17.31.46.mp4

After

CleanShot.2022-11-18.at.17.45.26.mp4

[christophpurrer]

Nice!

[Saadnajmi]

@amgleitman did you have a reason to keep these last merge? I remember they came up

[amgleitman]

@amgleitman did you have a reason to keep these last merge? I remember they came up

I added the lines that were being deleted as part of fc17709, which corresponds to 3f62904 in RNCore.

The removal of these lines in RNCore happened in 3e229f2, which didn't make it into a stable release until 0.69. That being said, if we want to remove it now and everything still works, then I say go for it. We'll have to get rid of it at some point anyway.