[Fabric] Shim RCTTextInputComponentView to work w/ Fabric #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
amgleitman
approved these changes
Dec 7, 2022
React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
Show resolved
Hide resolved
|
It's unfortunate that we can't test this component fully on Fabric macOS quite yet, but it makes sense given that it's still a work in progress. Here's hoping that day will come soon! |
…tInputComponentView
shwanton
changed the title
|
@amgleitman very soon we'll be able to build fabric on macOS & then we should have a better way to test these components! |
added 3 commits
December 7, 2022 17:16
…tInputComponentView
…tInputComponentView
|
closes #1553 |
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…1544) * Shim RCTTextInputComponentView to build w/ Fabric * Add missing tag * Add placeholder comment Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…1544) * Shim RCTTextInputComponentView to build w/ Fabric * Add missing tag * Add placeholder comment Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…1544) * Shim RCTTextInputComponentView to build w/ Fabric * Add missing tag * Add placeholder comment Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric on macOS implementation:
Shim RCTTextInputComponentView to work w/ Fabric
Closes #1553
Changelog
[macOS][Fabric] - Shim RCTTextInputComponentView for Fabric
Test Plan
[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no RCTTextInputComponentView errors
Build errors:
Build RNTester-macOS_2022-12-05T17-49-32.txt
[x] Build RNTester - iOS w/ Fabric - New architecture example should work
[x] Build RNTester-macOS w/ Paper - should work
[x] Build RNTester - iOS w/ Paper - should work
