Implement Flow type MacOSViewProps #1583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Dec 10, 2022
Saadnajmi
commented
Dec 10, 2022
Saadnajmi
commented
Dec 10, 2022
Saadnajmi
commented
Dec 10, 2022
Saadnajmi
commented
Dec 10, 2022
Base commit: 61c6788 |
mischreiber
reviewed
Dec 15, 2022
…cos into ViewPropsMacOS
|
@mischreiber could you take another look? |
mischreiber
approved these changes
Dec 16, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* Implement ViewPropsMacOS * lint * Add back Android ISS changes * PR feedback
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
May 1, 2024
Summary: * Implement ViewPropsMacOS * lint * Add back Android ISS changes * PR feedback Test Plan: See test plan in D45362318 Reviewers: shawndempsey, chpurrer, lefever, moti, helenistic Reviewed By: shawndempsey Differential Revision: https://phabricator.intern.facebook.com/D45444179 Tasks: T152048081 # Conflicts: # Libraries/Components/View/ViewPropTypes.js # Conflicts: # packages/react-native/Libraries/Components/View/ViewPropTypes.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
In preparation for the addition of Typescript types in RN 0.71, let's take some time to re-orgnaize our flow types. Particularly, let's separate macOS specific View props into a type
ViewPropsMacOS. This matchesIOSViewPropsandAndroidViewProps. Eventually, we can use this to inform our typescript typeViewPropsMacOSonce we sync to 0.71.Changelog
[macOS] [Added] - Implement Flow type MacOSViewProps
Test Plan
I did a text compare of our
ViewPropTypes.json RN Core at 0.68-stable and our fork to create this file.