[Fabric] Shim RCTScrollViewComponentView #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Saadnajmi merged 8 commits into microsoft:main from shwanton:fabric/shim-uiscrollviewdelegate

Dec 22, 2022

shwanton commented Dec 10, 2022 •

edited

Loading

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary

Fabric on macOS implementation:
Shim RCTScrollViewComponentView to work w/ Fabric

closes #1554

Changelog

[macOS][Added] - Shim RCTScrollViewComponentView for Fabric

Test Plan

[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no RCTScrollViewComponentView errors

Build errors:
Build RNTester-macOS_2022-12-09T16-25-02.txt

[x] Build RNTester - iOS w/ Fabric

[x] Build RNTester-macOS w/ Paper - should work

[x] Build RNTester - iOS w/ Paper -

should work


          [Fabric] Shim RCTEnhancedScrollView

3f876c7

shwanton marked this pull request as ready for review

December 10, 2022 01:03

shwanton requested a review from a team as a code owner

December 10, 2022 01:03

Shawn Dempsey added 2 commits

December 12, 2022 14:35


          Merge remote-tracking branch 'microsoft/main' into fabric/shim-uiscro…

ab43f59

…llviewdelegate


          Merge remote-tracking branch 'microsoft/main' into fabric/shim-uiscro…

9587dd8

…llviewdelegate

Saadnajmi self-assigned this


          Merge remote-tracking branch 'microsoft/main' into fabric/shim-uiscro…

609872b

…llviewdelegate

analysis-bot commented Dec 15, 2022 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: b4dd208
Branch: main

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTEnhancedScrollView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.h Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi reviewed

View reviewed changes

React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm Outdated Show resolved Hide resolved

Saadnajmi requested changes

View reviewed changes

Collaborator

Saadnajmi left a comment

See comments left

ghost added the Needs: Author Feedback label


          Merge remote-tracking branch 'microsoft/main' into fabric/shim-uiscro…

10de52b

…llviewdelegate

ghost removed the Needs: Author Feedback label

Author

shwanton commented Dec 22, 2022

Sorry for all the missing tags in this PR. It was the first one I tried to automate the process and obviously it didn't have great results.

Shawn Dempsey added 3 commits

December 21, 2022 17:03


          Fix missing tags

b627a16


          Fix bad tag

a9047ae


          Remove brackets from iOS specific tags

ee95062

Saadnajmi approved these changes

View reviewed changes

Saadnajmi merged commit 0c343d9 into microsoft:main

shwanton deleted the fabric/shim-uiscrollviewdelegate branch

December 22, 2022 18:51

shwanton added a commit to shwanton/react-native-macos that referenced this pull request


          [Fabric] Shim RCTScrollViewComponentView (microsoft#1584)

a504bb5

* [Fabric] Shim RCTEnhancedScrollView

* Fix missing tags

* Fix bad tag

* Remove brackets from iOS specific tags

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>

shwanton added a commit to shwanton/react-native-macos that referenced this pull request


          [Fabric] Shim RCTScrollViewComponentView (microsoft#1584)

1f8dd7d

* [Fabric] Shim RCTEnhancedScrollView

* Fix missing tags

* Fix bad tag

* Remove brackets from iOS specific tags

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>

shwanton added a commit to shwanton/react-native-macos that referenced this pull request


          [Fabric] Shim RCTScrollViewComponentView (microsoft#1584)

ca6527a

* [Fabric] Shim RCTEnhancedScrollView

* Fix missing tags

* Fix bad tag

* Remove brackets from iOS specific tags

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet