-
Notifications
You must be signed in to change notification settings - Fork 149
[Fabric] Shim RCTSliderComponentView #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric] Shim RCTSliderComponentView #1588
Conversation
|
Base commit: 9669c10 |
React/Fabric/Mounting/ComponentViews/Slider/RCTSliderComponentView.mm
Outdated
Show resolved
Hide resolved
React/Fabric/Mounting/ComponentViews/Slider/RCTSliderComponentView.mm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
React/Fabric/Mounting/ComponentViews/Slider/RCTSliderComponentView.mm
Outdated
Show resolved
Hide resolved
* Shim RCTSliderComponentView * Shim RCTUISlider properties * Refactor to use typedef * Fix tags when only disabling for macos * Missed a couple tags Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
* Shim RCTSliderComponentView * Shim RCTUISlider properties * Refactor to use typedef * Fix tags when only disabling for macos * Missed a couple tags Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Base/macOS/RCTUIKit.m # Conflicts: # React/Base/macOS/RCTUIKit.m # Conflicts: # React/Base/macOS/RCTUIKit.m
* Shim RCTSliderComponentView * Shim RCTUISlider properties * Refactor to use typedef * Fix tags when only disabling for macos * Missed a couple tags Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Base/macOS/RCTUIKit.m # Conflicts: # React/Base/macOS/RCTUIKit.m # Conflicts: # React/Base/macOS/RCTUIKit.m
Please select one of the following
Summary
Fabric on macOS implementation:
Shim RCTSliderComponentView and RCTUISlider
closes #1557
Changelog
[macOS][Fabric] - Shim RCTSliderComponentView enum and RCTUISlider
Test Plan
[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no RCTSliderComponentView build errors

[x] Build RNTester - iOS w/ Fabric

[x] Build RNTester-macOS w/ Paper - should work

[x] Build RNTester - iOS w/ Paper - should work
