Skip to content

Conversation

shwanton
Copy link

@shwanton shwanton commented Dec 13, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Fabric on macOS implementation:
Shim RCTSliderComponentView and RCTUISlider

closes #1557

Changelog

[macOS][Fabric] - Shim RCTSliderComponentView enum and RCTUISlider

Test Plan

[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no RCTSliderComponentView build errors
CleanShot 2022-12-12 at 18 03 53

[x] Build RNTester - iOS w/ Fabric
CleanShot 2022-12-12 at 18 06 59

[x] Build RNTester-macOS w/ Paper - should work
CleanShot 2022-12-12 at 18 14 34

[x] Build RNTester - iOS w/ Paper - should work
CleanShot 2022-12-12 at 18 12 25

@shwanton shwanton marked this pull request as ready for review December 13, 2022 02:19
@shwanton shwanton requested a review from a team as a code owner December 13, 2022 02:19
@pull-bot
Copy link

pull-bot commented Dec 15, 2022

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against eeb1458

@analysis-bot
Copy link

analysis-bot commented Dec 15, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 9669c10
Branch: main

Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

@ghost ghost removed the Needs: Author Feedback label Dec 22, 2022
@Saadnajmi Saadnajmi merged commit 4c3fb80 into microsoft:main Dec 22, 2022
@shwanton shwanton deleted the fabric/shim-rctslidercomponentview branch December 22, 2022 21:07
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
* Shim RCTSliderComponentView

* Shim RCTUISlider properties

* Refactor to use typedef

* Fix tags when only disabling for macos

* Missed a couple tags

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
* Shim RCTSliderComponentView

* Shim RCTUISlider properties

* Refactor to use typedef

* Fix tags when only disabling for macos

* Missed a couple tags

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
# Conflicts:
#	React/Base/macOS/RCTUIKit.m

# Conflicts:
#	React/Base/macOS/RCTUIKit.m

# Conflicts:
#	React/Base/macOS/RCTUIKit.m
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
* Shim RCTSliderComponentView

* Shim RCTUISlider properties

* Refactor to use typedef

* Fix tags when only disabling for macos

* Missed a couple tags

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
# Conflicts:
#	React/Base/macOS/RCTUIKit.m

# Conflicts:
#	React/Base/macOS/RCTUIKit.m

# Conflicts:
#	React/Base/macOS/RCTUIKit.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shim RCTSliderComponentView

5 participants