[Cherry-pick] Pick up upstream fix to NewAppScreen to remove a diff #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#27180) Summary: This pull request adds a missing key attribute to an array of elements in the example for `NewAppScreen`. This results in the "missing key" warning no longer appearing when viewing this example. [General] [Fixed] - RNTester: Add missing key attribute in NewAppScreen example Pull Request resolved: facebook#27180 Test Plan: When viewing this example in RNTester, this warning is no longer printed. Differential Revision: D18418198 Pulled By: mdvacca fbshipit-source-id: 8fbe51da7b714e3e94fd2186ea8cc4e3606d9f95
4 tasks
Base commit: 9f78517 |
chiuam
approved these changes
Dec 22, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…#27180) (microsoft#1608) Summary: This pull request adds a missing key attribute to an array of elements in the example for `NewAppScreen`. This results in the "missing key" warning no longer appearing when viewing this example. [General] [Fixed] - RNTester: Add missing key attribute in NewAppScreen example Pull Request resolved: facebook#27180 Test Plan: When viewing this example in RNTester, this warning is no longer printed. Differential Revision: D18418198 Pulled By: mdvacca fbshipit-source-id: 8fbe51da7b714e3e94fd2186ea8cc4e3606d9f95 Co-authored-by: empyrical <empyrical@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
75f853d had fixed this all the way back in RN 0.62, but we seemed to never pick it up. Let's pick it up now.
Changelog
[macOS] [Changed] - Remove a diff around the NewAppScreen example
Test Plan
CI passes.