Fix many compiler warnings #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base commit: e948c79 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Saadnajmi
commented
Jan 3, 2023
harrieshin
approved these changes
Jan 4, 2023
4 tasks
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* Bump to 68 * Add audited regions * Fix some more warnings * More nonnull * don't audit fabric types * Audit just the macOS Fabric regions * Add to RCTSlider * More warning fixes * More warning fixes * Fix up opaque * Remove override of opaque
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our "Integration CI" was failing, because some clang warnings (nullability-completeness) started being treated as errors. This got fixed by react-native-test-app ignoring that warning (microsoft/react-native-test-app#1259) but we should still fix the warnings in our repo.
This change fixes a lot of compiler warnings, including:
RCTEventDispatchertoid<RCTEventDispatcherProtocol#defineuses intotypedefusesRCTUIViewinstead of RCTPlatformViewopaqueproperty that Xcode warned aboutopaqueis readwrite onUIView, butreadonlyon macOS. t looks like we were trying to change thereadonlyproperty into areadwritewith an override, but Xcode told us it would ignore our definition and auto synthesize the base definition. So I removed our attempted override, and moved calls ofself.opaque = NOto iOS only ifdefs. End result should be the same compiled code, but less warnings.Changelog
[INTERNAL] [FIXED] - Fixed many compiler warnings
Test Plan
CI passes.