Remove diff in RCTImageLoader

[Saadnajmi]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

This came up during the 0.71 merge. There was an iOS only method we had already shimmed in RCTUIKit:

NSData *UIImagePNGRepresentation(NSImage *image) {
  return NSImageDataForFileType(image, NSBitmapImageFileTypePNG, @{});
}

NSData *UIImageJPEGRepresentation(NSImage *image, CGFloat compressionQuality) {
  return NSImageDataForFileType(image,
                                NSBitmapImageFileTypeJPEG,
                                @{NSImageCompressionFactor: @(1.0)});
}

As it turns out, we can't depend on RCTUIKit here, because this file's podspec (React-RCTImage) doesn't take a dependency on RCTUIKit's pod React-Core. The #import <React/RCTUIKit.h> most likely worked out of happenstance. I went with copying the methods needed from RCTUIKit to RCTImageLoader as we already had some duplication.

Let's also fix a bug where compressionQuality was hardcoded.

Changelog

[macOS] [Fixed] - Remove unnecessary diff in RCTImageLoader

Test Plan

CI should pass

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 7222926
Branch: main

[Saadnajmi]

As it turns out, we can't depend on RCTUIKit here, because this file's podspec (React-RCTImage) doesn't take a dependency on RCTUIKit's pod React-Core. The #import <React/RCTUIKit.h> most likely worked out of happenstance.

I went with copying the methods needed over to the other file, as we already had some duplication. Let me know if there's an issue with this approach. I can also just close the PR and leave things as is.