Skip to content

Revert nextKeyViewTag prop #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2023
Merged

Revert nextKeyViewTag prop #1621

merged 1 commit into from
Jan 14, 2023
+0 −198

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This reverts commit 14ce7dc.
This prop:

  • Requires very specific changes to your native window (autoRecalculatesKeyViewLoop = false)
  • Was never used by client teams because...
  • we just created a FocusZone in FluentUI React Native instead

Removing for 0.71+.

Changelog

[macOS] [Removed] - Removed nextKeyViewTag prop

Test Plan

CI should pass

@Saadnajmi Saadnajmi requested a review from a team as a code owner January 5, 2023 23:57
@Saadnajmi Saadnajmi changed the title Revert keyview lepp Revert "Add support for modifying the key view loop #769" Jan 5, 2023
@Saadnajmi Saadnajmi changed the title Revert "Add support for modifying the key view loop #769" Revert nextKeyViewTag prop Jan 5, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 9cc31ce
Branch: main

@Saadnajmi Saadnajmi mentioned this pull request Jan 6, 2023
Merged
4 tasks
@Saadnajmi Saadnajmi force-pushed the revert-keyview-lepp branch 3 times, most recently from 07aa099 to a2c7bab Compare January 14, 2023 08:00
@Saadnajmi Saadnajmi force-pushed the revert-keyview-lepp branch from a2c7bab to d32f585 Compare January 14, 2023 08:39
@Saadnajmi Saadnajmi merged commit 829e6b1 into microsoft:main Jan 14, 2023
@Saadnajmi Saadnajmi deleted the revert-keyview-lepp branch January 14, 2023 20:57
Saadnajmi added a commit to shwanton/react-native-macos that referenced this pull request Jan 14, 2023
@Saadnajmi
Revert "Add support for modifying the key view loop (microsoft#769)" (m…
1fc2d1d 
…icrosoft#1621)

This reverts commit 14ce7dc.
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
@Saadnajmi
Revert "Add support for modifying the key view loop (microsoft#769)" (m…
fc31846 
…icrosoft#1621)

This reverts commit 14ce7dc.
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
@Saadnajmi
Revert "Add support for modifying the key view loop (microsoft#769)" (m…
c1a4ee0 
…icrosoft#1621)

This reverts commit 14ce7dc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischreiber mischreiber mischreiber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi @analysis-bot @mischreiber