forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 149
Return and Space keys do not trigger onPress events #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tom-un
merged 62 commits into
microsoft:main
from
tom-un:user/tomun/fixPressibilityKeyEvents
Jan 12, 2023
Merged
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
685f103
Update scripts to publish react-native-macos-init
tom-un 8ccd26c
Merge remote-tracking branch 'ms/master'
tom-un 45d2ee2
Merge remote-tracking branch 'ms/master'
tom-un 1e2c329
Clean up merge markers
tom-un 408dae3
Merge remote-tracking branch 'ms/master'
tom-un bdaa8ad
Merge remote-tracking branch 'ms/master'
tom-un 5a67ae0
Restored ios:macos RNTester parity except for InputAccessoryView.
tom-un e5a6df2
Revert "Restored ios:macos RNTester parity except for InputAccessoryV…
tom-un 4bca23c
Merge remote-tracking branch 'ms/master'
tom-un d067629
Merge remote-tracking branch 'ms/master'
tom-un 6ed01c8
Merge remote-tracking branch 'ms/master'
tom-un ae5cc57
Merge remote-tracking branch 'ms/master'
tom-un caf0975
Merge remote-tracking branch 'ms/master'
tom-un e3fbee9
Merge remote-tracking branch 'ms/master'
tom-un a75050c
Merge remote-tracking branch 'ms/master'
tom-un 3a77e37
Merge remote-tracking branch 'ms/master'
tom-un d10ff74
Merge remote-tracking branch 'ms/master'
tom-un dd11d73
Merge remote-tracking branch 'ms/master'
tom-un ba2730b
Merge remote-tracking branch 'ms/master'
tom-un 5da14a9
Remove unnecessary android builds and tar file upload.
tom-un b1a873b
Merge remote-tracking branch 'ms/master'
rnbot bca9ae9
Merge remote-tracking branch 'ms/master'
rnbot 7ff5624
Merge remote-tracking branch 'ms/master'
rnbot 1056600
Merge remote-tracking branch 'ms/master'
rnbot d3422e3
Merge remote-tracking branch 'ms/master'
rnbot 92c66ac
Merge remote-tracking branch 'ms/master'
rnbot b295454
Merge remote-tracking branch 'ms/master'
rnbot 1bdf8c7
Merge remote-tracking branch 'ms/master'
rnbot b880837
Merge remote-tracking branch 'ms/master'
rnbot 3c7c7c3
Merge remote-tracking branch 'ms/master'
rnbot 93c5ecb
Merge remote-tracking branch 'ms/master'
rnbot 04ba713
Merge remote-tracking branch 'ms/master'
rnbot b3be546
Merge remote-tracking branch 'ms/master'
tom-un 046bde3
Merge remote-tracking branch 'ms/master'
tom-un 302493e
Merge remote-tracking branch 'ms/master'
tom-un 4ebb937
Merge remote-tracking branch 'ms/master'
tom-un 5bdb247
Merge remote-tracking branch 'ms/master'
tom-un 07bea18
Merge remote-tracking branch 'ms/master'
tom-un 51f76ed
Merge remote-tracking branch 'ms/master'
tom-un 6f814b4
Merge remote-tracking branch 'ms/master'
tom-un e69efe4
Merge remote-tracking branch 'ms/master'
tom-un 76449c6
Merge remote-tracking branch 'ms/master'
tom-un 6746b18
Merge remote-tracking branch 'ms/master'
tom-un e822b86
Merge remote-tracking branch 'ms/master'
tom-un e6f9e2d
Merge remote-tracking branch 'ms/master'
tom-un 0676b93
Merge remote-tracking branch 'ms/master'
tom-un ab4a6d9
Merge remote-tracking branch 'ms/master'
tom-un ca7617f
Merge remote-tracking branch 'ms/master' into master
tom-un f226a7d
Merge remote-tracking branch 'ms/master' into master
tom-un 582cfba
Merge remote-tracking branch 'ms/master' into master
tom-un edfd0ee
Merge remote-tracking branch 'ms/master' into master
tom-un b3572bb
Merge remote-tracking branch 'ms/master' into master
tom-un c3c3957
Merge remote-tracking branch 'ms/master' into master
tom-un 9189e5e
Merge remote-tracking branch 'upstream/master'
tom-un 5a7b082
Merge branch 'microsoft:main' into master
tom-un dd95e94
Merge branch 'microsoft:main' into master
tom-un 2497bb7
Fix pressability enter/return and spacebar key events
tom-un 5ad9a1b
Don't change validKeysDown/Up for components that explicitly set them
tom-un f05167a
Added event.defaultPrevented check to key events
tom-un 550da45
Fixed spacing in RCTView.m
tom-un b3cc601
Ignore key event props not matching press events
tom-un 4f1e62a
Update Pressability.js
Saadnajmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.