[0.68] Return and Space keys do not trigger onPress events #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae0. * Remove unnecessary android builds and tar file upload. * Fix pressability enter/return and spacebar key events * Don't change validKeysDown/Up for components that explicitly set them * Added event.defaultPrevented check to key events * Fixed spacing in RCTView.m * Ignore key event props not matching press events Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com>
mischreiber
approved these changes
Jan 12, 2023
|
Thank for doing this! |
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…icrosoft#1632) * Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae0. * Remove unnecessary android builds and tar file upload. * Fix pressability enter/return and spacebar key events * Don't change validKeysDown/Up for components that explicitly set them * Added event.defaultPrevented check to key events * Fixed spacing in RCTView.m * Ignore key event props not matching press events Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com> Co-authored-by: Tom Underhill <tomun@microsoft.com> Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick 400430a to 0.68-stable.