[Fabric] Fix NativeComponentExample not rendering on Fabric #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! When I had the code looking like this before, it failed the newly added Fabric CI. I'm curious to see if it will pass now :) |
Saadnajmi
approved these changes
Jan 18, 2023
|
Oops, this broke Paper on iOS 😓 I'll fix it so that we only render when fabric is available |
|
My understanding is that Turbomodule codegen discovery is somewhat broken at this point in time and the actual paper implementation for RNTMyNativeView isn't getting linked :/. I'm hoping this will be resolved after we sync to 0.71 |
|
Found a temporary fix that won't throw error when trying to render on Paper. Paper Fabric |
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…t#1662) * Fix NativeComponentExample not rendering on Fabric * Add back fabric check and conditionally render the example * Update macOS tags & re-add comment Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…t#1662) * Fix NativeComponentExample not rendering on Fabric * Add back fabric check and conditionally render the example * Update macOS tags & re-add comment Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…t#1662) * Fix NativeComponentExample not rendering on Fabric * Add back fabric check and conditionally render the example * Update macOS tags & re-add comment Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The
NativeComponentExampleis currently not rendering when building for fabric on iOS.ref._internalInstanceHandle?.stateNode?.canonicalis undefined.https://github.com/microsoft/react-native-macos/blob/main/packages/rn-tester/NativeComponentExample/js/MyNativeView.js#L38
Upstreamed the latest
MyNativeView.jsfrom https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeComponentExample/js/MyNativeView.jsChangelog
[macOS][Fabric] - Fix NativeComponentExample to render correctly
Test Plan
Before
CleanShot.2023-01-18.at.14.45.05.mp4
After
CleanShot.2023-01-18.at.14.26.00.mp4