Skip to content

Conversation

ospfranco
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Takes care of #1395

Changelog

[General] [Fixed] - Fixes caret changing sizes if text field is empty

Test Plan

Set a larger font size on a single line text field and watch the caret change sizes when the field is empty

@ospfranco ospfranco requested a review from a team as a code owner January 19, 2023 11:04
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This should make it to our 0.71 release. I think this will fix this for both Paper and Fabric. We'll see when Fabric is actually usable :)

@Saadnajmi Saadnajmi merged commit a80fba1 into microsoft:main Jan 25, 2023
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants